Fix #8313: Correct capitalization on baseset filenames #8322
Conversation
|
This seems odd. Looking at the commit history these files have basically never changed, and there are definitely DOS-graphics users on Linux. Per the comments on a similar (ancient!) bug #2408, this is supposed to be a case-insensitive lookup on Linux also. That must have broken at some point, and I think fixing it there would be more reliable than this change. EDIT: That said, this seems reasonable for consistency if nothing else. |
TrueBrain
added
needs triage
|
The code tries to open files first based on the capitalization used by the source; if that fails it tries again with everything in lowercase. So that means that many of the cases in this PR should not be needed; a few are worth checking out, and might have caused the problem: they are lowercase in the source, and appear to be uppercase in the DOS archive. I will investigate this a bit further. |
|
Confirmed. Only lowercase -> uppercase should happen. Created new PR to address only those. Going to close this one now in favour of that one. Thank you for figuring out what the problem was! Hope you don't mind I solved it this way :D |
Updates baseset filenames to use correct capitalization based on original game's file structure. Caused issues on Linux when trying to use the original game's files.