Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wezterm: add licenses, install extra files, and update to a revision of 20210314 #106976

Closed

Conversation

steveej
Copy link
Contributor

@steveej steveej commented Dec 15, 2020

Motivation for this change
  • Missing licenses
  • New version

Follows up on #104704

/cc @teto

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

lib/licenses.nix Outdated
@@ -55,6 +55,11 @@ lib.mapAttrs (n: v: v // { shortName = n; }) {
free = false;
};

angle = {
fullName = "ANGLE";
url = "https://github.com/google/angle/blob/master/LICENSE";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This license seems to be bsd3, wikipedia also register it as BSD 3 https://en.wikipedia.org/wiki/ANGLE_(software)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marsam. I changed it to bsd3

@steveej steveej changed the title wezterm: add licenses and update to a revision of 12th Dec 2020 wezterm: add licenses and update to a revision of 15th Dec 2020 Dec 16, 2020
@bew
Copy link
Contributor

bew commented Mar 23, 2021

For your information, there's a new release of Wezterm from 2021-03-14:
https://wezfurlong.org/wezterm/changelog.html#20210314-114017-04b7cedd

@steveej steveej changed the title wezterm: add licenses and update to a revision of 15th Dec 2020 wezterm: add licenses, install extra files, and update to a revision of 20210314 Mar 24, 2021
done

install -Dm644 assets/shell-integration/* -t $out/etc/profile.d
Copy link
Contributor

@bew bew Mar 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shell integration is optional to use wezterm, if you put it in $out/etc/profile.d does it make it always loaded ?
For example I don't want to load this when installing wezterm.

@nh2 nh2 mentioned this pull request Apr 2, 2021
@steveej
Copy link
Contributor Author

steveej commented Apr 7, 2021

Closing this in favor of #118712

@steveej steveej closed this Apr 7, 2021
@steveej steveej deleted the pr/wezterm-update-2020-12-15 branch April 7, 2021 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants