New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: for original terrain generator, keep a single gap of water at the borders #7883
Fix: for original terrain generator, keep a single gap of water at the borders #7883
Conversation
SamuXarick
commented
Dec 29, 2019
- When freeform_edges was on, NE and NW borders could have terrain adjacent to the void tiles
- SE and SW borders minimum gap was 2-tile wide instead of 1
dbb41b2
to
ca93dbd
Compare
ca93dbd
to
9135a4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably fine.
9135a4d
to
9e6e669
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the issues locally; will push it in a sec. Wanted to leave the feedback behind for posterity.
9e6e669
to
0c4918f
Compare
Ah, figured it. Reworked the patch a bit to have less lines. Will merge later :) |
I think this is wrong. |
Nothing changed there, it can still be sloped. What this changes, is what the generator outputs. It used to be that with 2 borders it should be sloped, but the other two always had 2 tiles of water, during generation. That just looks odd. The only real choice here is, I guess, if it should generate sloped borders; if so, it should do that in all 4 borders ;) But that really does look ugly :) |
…e borders This means that for NE/NW, it should have one more in case of freeform-edges, and in case of SE/SW it should have one less. Reminder: freeform-edges only adds VOID tiles on X=0 and Y=0.
0c4918f
to
90db639
Compare