Fix #8313: use correct capitalization for TTO / DOS base-music #8385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrueBrain
added
candidate: yes
|
Ah, I forgot that OpenTTD tries lowercase as well. So this works no matter whether the OS changes the case for old DOS-uppercase-only filenames :) |
frosch123
previously approved these changes
Dec 15, 2020
DOS did not have cases in filenames. Different OS interpret them as either all-lowercase or all-uppercase. So we try both. All-uppercase is done by the obg/obm/obs files, and if opening fails, OpenTTD will automatically retry the all-lowercase variant. So for those who already have the files lowercase, nothing changes. For those that install fresh from TTO, it should now work out-of-the-box.
frosch123
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOS did not have cases in filenames. Different OS interpret
them as either all-lowercase or all-uppercase. So we try both.
All-uppercase is done by the obg/obm/obs files, and if opening
fails, OpenTTD will automatically retry the all-lowercase variant.
So for those who already have the files lowercase, nothing
changes. For those that install fresh from TTO, it should now
work out-of-the-box.
This is an alternative to #8322, which also changed a lot of entries to lowercase. This seems to be the wrong move: in the way OpenTTD works, lowercase is always checked anyway.