Fix: Remove unnessary reference to suppress warning #8337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be honest, I feel like removing the reference is the better solution here. Taking a reference of a const pointer is fairly ...pointless |
|
@bc-lee : would you feel up for this? Instead of suppressing the warning, fixing the cause? Would be really awesome if you can fix it :) It is annoying the hell out of me on every CI run :P |
TrueBrain
added
waiting on author
candidate: probably not
Apple Clang version 12 (bundled with Xcode 12) complaints about copying small objects in range loop (-Wrange-loop-analysis introduced by -Wall). This warning can be easily avoided by removing the reference from the const pointer type.
TrueBrain
added
needs review
and removed
work: needs more work
bc-lee
changed the title
|
@TrueBrain It turns out, fixing this without side effects is almost trivial, so I did it. PTAL. |
LordAro
approved these changes
Dec 15, 2020
|
Thank you very much, also for the quick reply/fix :D Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple Clang version 12 (bundled with Xcode 12) complaints about copying
small objects in range loop (-Wrange-loop-analysis introduced by -Wall).
This warning can be easily avoided by removing the reference from
the const pointer type.