Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USB Decoder does not function correctly. #361

Closed
Codysseus opened this issue Dec 3, 2020 · 4 comments
Closed

USB Decoder does not function correctly. #361

Codysseus opened this issue Dec 3, 2020 · 4 comments
Assignees
@azonenberg
Labels
bug Something isn't working

Comments

@Codysseus
Copy link

I wrote a simple test case for the USB decoder that the offset of a given packet plus the length did not exceed the offset of the next packet. However, when I tried this on my own data I found that this did not hold true.
Here is a link to the modified usbcsv example with the test, and here is a link to the 7z that contains the csv in question. Be careful as the CSV is almost 2GB.
azonenberg added a commit that referenced this issue Dec 4, 2020
@azonenberg
DecodeData: correctly calculate DATA packet length. See #361.
a639676
@azonenberg
Copy link
Collaborator

Just checking whether the fixes I mentioned on IRC solved this?

@azonenberg azonenberg self-assigned this Dec 6, 2020
@azonenberg azonenberg added the bug Something isn't working label Dec 6, 2020
@Codysseus
Copy link
Author

Codysseus commented Dec 7, 2020 •
edited

Hey Andrew! Thank you for following up with this. At the moment I do not have the bandwidth to debug, but I will get back to you on Tuesday (Dec 08 2020) with what I have tried. I hope you had a nice weekend!

Here is what I have done: I changed the speed of the PMA decoder to Low Speed. After this the Packet Decoder did not have anything in the packets vector. Inside the waveform were TYPE_ERROR symbols.

@Codysseus
Copy link
Author

So one thing RE: my sample. Channel 0-Analog is D-, and Channel 1-Analog is D+. I was able to load a Low Speed sample into glscopeclient and it seemed to label the sample correctly. I flipped the channels and set it to Low Speed, now packets are emitted, but there is still an overlap issue. Here is a picture.

image

@Codysseus
Copy link
Author

Hello Andrew,
Just wanted to update this. I tested the decoder again, and the decoder works in the glscopeclient. It must be something to do with the configuration of the headless program.
Bug issue closed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azonenberg azonenberg

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@azonenberg @Codysseus