Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] gdb: Fix crash when exiting TUI with gdb -tui #106981

Merged
merged 1 commit into from Dec 27, 2020

Conversation

lsix
Copy link
Member

@lsix lsix commented Dec 15, 2020

Motivation for this change

Fixes #106868

This bug have been already been fixup in upstream and the fix version is already available in master. This commit backports the fix to gdb-9.2 which is the supported version in release-20.09.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @jamii

@lsix lsix changed the title gdb: Fix crash when exiting TUI with gdb -tui [20.09] gdb: Fix crash when exiting TUI with gdb -tui Dec 15, 2020
@ofborg ofborg bot requested review from globin and nbp December 15, 2020 22:19
@lsix lsix changed the base branch from release-20.09 to staging-20.09 December 16, 2020 08:48
@lsix
Copy link
Member Author

lsix commented Dec 16, 2020

I’ve changed the base to target staging-20.09 given the amount of rebuilds.

@lsix lsix merged commit 5bcf142 into NixOS:staging-20.09 Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant