Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: [NewGRF] Action 7/9 conditions 0x0B to 0x12 failed, if 'param' was 0x85 or 0x88. #8382

Merged
merged 1 commit into from Dec 15, 2020
Merged

Fix: [NewGRF] Action 7/9 conditions 0x0B to 0x12 failed, if 'param' was 0x85 or 0x88. #8382

merged 1 commit into from Dec 15, 2020

Conversation

frosch123
Copy link
Member

This fixes the rest of #7823, that was not yet fixed in 7f351fd .

@frosch123
Fix: [NewGRF] Action 7/9 conditions 0x0F to 0x12 failed, if 'param' w…
83c1ef8 
…as 0x88.

Fix: [NewGRF] Action 7/9 conditions 0x0B to 0x12 failed, if 'param' was 0x85.
These conditions are supposed to ignore 'param' entirely.
@frosch123 frosch123 mentioned this pull request Dec 15, 2020
Closed
@TrueBrain TrueBrain added candidate: yes This Pull Request is a candidate for being merged needs review: NewGRF Review requested from a NewGRF expert size: trivial This Pull Request is trivial labels Dec 15, 2020
TrueBrain
TrueBrain approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@TrueBrain TrueBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the code is nothing wrong; and I am pretty sure that if you made a boo-boo here, someone will complain, and we will fix that :)

@frosch123 frosch123 merged commit d5f05fb into OpenTTD:master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrueBrain TrueBrain TrueBrain approved these changes

Assignees
No one assigned
Labels
candidate: yes This Pull Request is a candidate for being merged needs review: NewGRF Review requested from a NewGRF expert size: trivial This Pull Request is trivial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@frosch123 @TrueBrain