@rmcgibbo please fix the eval error of ofborg.

Thanks, @SuperSandro2000. Looks like I didn't structure the package correctly for ofborg given the fact that it needs sources from multiple repos. I'll try to follow this design pattern: https://discourse.nixos.org/t/how-to-create-package-with-multiple-sources/9308/3

@jonringer: Sure, will do.

I'm not totally sure how to reproduce the ofborg failure locally. First attempts to move the external sources into a single 'srcs' are failing with

error: cannot coerce a set to a string, at /home/mcgibbon/projects/nixpkgs/pkgs/development/interpreters/python/mk-python-derivation.nix:111:5
(use '--show-trace' to show detailed location information)

so i'll try to fix that.

you pass it a list, not a set

Looks like I'm still hitting an ofborg failure, where the builtins.fetchTarball (one of the srcs) won't pull down in restricted mode.

Fixed w/ force push.

Result of nixpkgs-review pr 107268 run on x86_64-darwin 1

  100   391  100   391    0     0     73      0  0:00:05  0:00:05 --:--:-- 18619                                                                                                              100 2530k  100 2530k    0     0   378k      0  0:00:06  0:00:06 --:--:-- 4571k                                                                                                              unpacking source archive /private/tmp/nix-build-source.drv-0/AvalonToolkit_1.2.0.source.tar                                                                                                 error: zip file must contain a single file or directory.                                                                                                                                    hint: Pass stripRoot=false; to fetchzip to assume flat list of files

Thanks for the reviews. I think I've addressed all of the comments with the latest force-push.

Can you please put the changes from the review commit into the corresponding init commits?

Result of nixpkgs-review pr 107268 run on x86_64-darwin 1

Fails to build on darwin because inchi failds to build:

these derivations will be built:
  /nix/store/93dwx0vanag5scwr3yf5818lzv8zzb0j-inchi-1.05.drv
building '/nix/store/93dwx0vanag5scwr3yf5818lzv8zzb0j-inchi-1.05.drv'...
unpacking sources
unpacking source archive /nix/store/7j8zpnzw37y1g3pwyv9ds718ljgjqjc9-INCHI-1-SRC.zip
source root is INCHI-1-SRC
setting SOURCE_DATE_EPOCH to timestamp 1486122502 of file INCHI-1-SRC/INCHI_BASE/src/runichi2.c
patching sources
configuring
no configure script, doing nothing
building
build flags: -j4 -l4 SHELL=/nix/store/drz9yxh2v1swn9yl88c8w5g0x69b8wk2-bash-4.4-p23/bin/bash
gcc -fPIC -DTARGET_API_LIB -DCOMPILE_ANSI_ONLY -ansi -O3 -c ../../../INCHI_BASE/src/ichican2.c
gcc -fPIC -DTARGET_API_LIB -DCOMPILE_ANSI_ONLY -ansi -O3 -c ../../../INCHI_BASE/src/ichicano.c
gcc -fPIC -DTARGET_API_LIB -DCOMPILE_ANSI_ONLY -ansi -O3 -c ../../../INCHI_BASE/src/ichi_io.c
gcc -fPIC -DTARGET_API_LIB -DCOMPILE_ANSI_ONLY -ansi -O3 -c ../../../INCHI_BASE/src/ichierr.c
/nix/store/drz9yxh2v1swn9yl88c8w5g0x69b8wk2-bash-4.4-p23/bin/bash: gcc: command not found
/nix/store/drz9yxh2v1swn9yl88c8w5g0x69b8wk2-bash-4.4-p23/bin/bash: gcc: command not found
make: *** [makefile:196: ichicano.o] Error 127
make: *** Waiting for unfinished jobs....
make: *** [makefile:196: ichican2.o] Error 127
/nix/store/drz9yxh2v1swn9yl88c8w5g0x69b8wk2-bash-4.4-p23/bin/bash: gcc: command not found
make: *** [makefile:196: ichi_io.o] Error 127
/nix/store/drz9yxh2v1swn9yl88c8w5g0x69b8wk2-bash-4.4-p23/bin/bash: gcc: command not found
make: *** [makefile:196: ichierr.o] Error 127
builder for '/nix/store/93dwx0vanag5scwr3yf5818lzv8zzb0j-inchi-1.05.drv' failed with exit code 2
error: build of '/nix/store/93dwx0vanag5scwr3yf5818lzv8zzb0j-inchi-1.05.drv' failed

Build fixed on darwin, and previous review comments incorporated into the per-package commits.

@jonringer: Thanks. Fixes applied.

Result of nixpkgs-review pr 107268 run on x86_64-darwin 1

Result of nixpkgs-review pr 107268 run on x86_64-linux 1

(Friendly ping on this PR)

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107268 run on x86_64-linux 1

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107268 run on x86_64-darwin 1

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107268 run on x86_64-linux 1

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107268 run on x86_64-darwin 1

Thanks for the report on Darwin, Sando. I think I've fix it now with some more darwin-specific fixups in libinchi.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107268 run on x86_64-darwin 1