Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: deluge: enable tests #107259

Closed
wants to merge 1 commit into from
Closed

WIP: deluge: enable tests #107259

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 20, 2020 •
edited by ghost

fixes #107201

Current status:

deluge/plugins/Stats/deluge_stats/tests/test_stats.py ..F                [  1%]
deluge/plugins/WebUi/deluge_webui/tests/test_plugin_webui.py .           [  1%]
deluge/tests/test_alertmanager.py ..                                     [  2%]
deluge/tests/test_authmanager.py .                                       [  2%]
deluge/tests/test_bencode.py ...                                         [  3%]
deluge/tests/test_client.py [...] FFFFFFFF                               [  6%]
deluge/tests/test_common.py ..................                           [ 13%]
deluge/tests/test_component.py ......FE....                              [ 18%]
deluge/tests/test_config.py .........                                    [ 21%]
deluge/tests/test_core.py ................................F              [ 34%]
deluge/tests/test_decorators.py ..                                       [ 35%]
deluge/tests/test_error.py ....                                          [ 36%]
deluge/tests/test_files_tab.py FFFFF                                     [ 38%]
deluge/tests/test_httpdownloader.py ..............                       [ 43%]
deluge/tests/test_json_api.py FFFFFFFFF                                  [ 47%]
deluge/tests/test_log.py .                                               [ 47%]
deluge/tests/test_maketorrent.py ...                                     [ 48%]
deluge/tests/test_metafile.py ..                                         [ 49%]
deluge/tests/test_plugin_metadata.py ..                                  [ 50%]
deluge/tests/test_rpcserver.py ......                                    [ 52%]
deluge/tests/test_security.py ssssssssssssssssssssssssssssssssssssssssss [ 68%]
                                                                         [ 68%]
deluge/tests/test_sessionproxy.py ......                                 [ 71%]
deluge/tests/test_torrent.py ..F....Fs.                                  [ 75%]
deluge/tests/test_torrentmanager.py ....s                                [ 76%]
deluge/tests/test_torrentview.py FFFFFF                                  [ 79%]
deluge/tests/test_tracker_icons.py F.FFs                                 [ 81%]
deluge/tests/test_transfer.py ......                                     [ 83%]
deluge/tests/test_ui_common.py ..                                        [ 84%]
deluge/tests/test_ui_console.py ..                                       [ 85%]
deluge/tests/test_ui_entry.py ...FF....FFF............                   [ 94%]
deluge/tests/test_web_api.py FFFFFFFFFFFFF                               [ 99%]
deluge/tests/test_web_auth.py .                                          [ 99%]
deluge/tests/test_webserver.py F                                         [100%]
[...]
= 55 failed, 160 passed, 45 skipped, 152 warnings, 1 error in 198.18s (0:03:18) =

With python 3.7 it looks like this:

deluge/plugins/Stats/deluge_stats/tests/test_stats.py ..F                [  1%]
deluge/plugins/WebUi/deluge_webui/tests/test_plugin_webui.py .           [  1%]
deluge/tests/test_alertmanager.py ..                                     [  2%]
deluge/tests/test_authmanager.py .                                       [  2%]
deluge/tests/test_bencode.py ...                                         [  3%]
deluge/tests/test_client.py FFFFFFFF                                     [  6%]
deluge/tests/test_common.py ..................                           [ 13%]
deluge/tests/test_component.py ...........                               [ 18%]
deluge/tests/test_config.py .........                                    [ 21%]
deluge/tests/test_core.py ................................F              [ 34%]
deluge/tests/test_decorators.py ..                                       [ 35%]
deluge/tests/test_error.py ....                                          [ 36%]
deluge/tests/test_files_tab.py FFFFF                                     [ 38%]
deluge/tests/test_httpdownloader.py ..............                       [ 43%]
deluge/tests/test_json_api.py FFFFFFFFF                                  [ 47%]
deluge/tests/test_log.py .                                               [ 47%]
deluge/tests/test_maketorrent.py ...                                     [ 48%]
deluge/tests/test_metafile.py ..                                         [ 49%]
deluge/tests/test_plugin_metadata.py ..                                  [ 50%]
deluge/tests/test_rpcserver.py ......                                    [ 52%]
deluge/tests/test_security.py ssssssssssssssssssssssssssssssssssssssssss [ 68%]
                                                                         [ 68%]
deluge/tests/test_sessionproxy.py ......                                 [ 71%]
deluge/tests/test_torrent.py ..F....Fs.                                  [ 75%]
deluge/tests/test_torrentmanager.py ....s                                [ 76%]
deluge/tests/test_torrentview.py FFFFFF                                  [ 79%]
deluge/tests/test_tracker_icons.py F.FFs                                 [ 81%]
deluge/tests/test_transfer.py ......                                     [ 83%]
deluge/tests/test_ui_common.py ..                                        [ 84%]
deluge/tests/test_ui_console.py ..                                       [ 85%]
deluge/tests/test_ui_entry.py ...FF....FFF............                   [ 94%]
deluge/tests/test_web_api.py FFFFFFFFFFFFF                               [ 99%]
deluge/tests/test_web_auth.py .                                          [ 99%]
deluge/tests/test_webserver.py F                                         [100%]
[...]
===== 54 failed, 161 passed, 45 skipped, 98 warnings in 198.11s (0:03:18) ======

With the latest deluge develop commit (23a48dd01c86ef01cd1d13371de51247ec9a503b) and python 3.8 it looks like this:

deluge/plugins/Stats/deluge_stats/tests/test_stats.py ..F                [  1%]
deluge/plugins/WebUi/deluge_webui/tests/test_plugin_webui.py .           [  1%]
deluge/tests/test_alertmanager.py ..                                     [  2%]
deluge/tests/test_authmanager.py .                                       [  2%]
deluge/tests/test_bencode.py ...                                         [  3%]
deluge/tests/test_client.py FFFFFFFF                                     [  6%]
deluge/tests/test_common.py ..................                           [ 13%]
deluge/tests/test_component.py ...........                               [ 17%]
deluge/tests/test_config.py ..........                                   [ 21%]
deluge/tests/test_core.py ................................F              [ 33%]
deluge/tests/test_decorators.py ..                                       [ 34%]
deluge/tests/test_error.py ....                                          [ 36%]
deluge/tests/test_files_tab.py FFFFF                                     [ 37%]
deluge/tests/test_httpdownloader.py ..............                       [ 43%]
deluge/tests/test_json_api.py FFFFFFFFF                                  [ 46%]
deluge/tests/test_log.py .                                               [ 46%]
deluge/tests/test_maketorrent.py ...                                     [ 48%]
deluge/tests/test_metafile.py ..                                         [ 48%]
deluge/tests/test_plugin_metadata.py ..                                  [ 49%]
deluge/tests/test_rpcserver.py ......                                    [ 51%]
deluge/tests/test_security.py ssssssssssssssssssssssssssssssssssssssssss [ 67%]
                                                                         [ 67%]
deluge/tests/test_sessionproxy.py ......                                 [ 69%]
deluge/tests/test_torrent.py ...F....Fs.                                 [ 74%]
deluge/tests/test_torrentmanager.py .....s                               [ 76%]
deluge/tests/test_torrentview.py FFFFFF                                  [ 78%]
deluge/tests/test_tracker_icons.py F.FFs                                 [ 80%]
deluge/tests/test_transfer.py ......                                     [ 82%]
deluge/tests/test_ui_common.py ..                                        [ 83%]
deluge/tests/test_ui_console.py ...                                      [ 84%]
deluge/tests/test_ui_entry.py ...FF....FFFF............                  [ 93%]
deluge/tests/test_ui_gtk3.py .                                           [ 94%]
deluge/tests/test_web_api.py FFFFFFFFFFFFF                               [ 99%]
deluge/tests/test_web_auth.py .                                          [ 99%]
deluge/tests/test_webserver.py F                                         [100%]
[...]
============ 55 failed, 166 passed, 45 skipped in 203.34s (0:03:23) ============

It's the same wiith the latest deluge develop commit (23a48dd01c86ef01cd1d13371de51247ec9a503b) and python 3.7.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost ghost requested a review from dtzWill December 20, 2020 15:01
@ofborg ofborg bot requested review from domenkozar and ebzzry December 20, 2020 15:10
@ghost
Copy link
Author

ghost commented Apr 29, 2021

I'm not planning to work on this anymore

@ghost ghost closed this Apr 29, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill Awaiting requested review from dtzWill

@domenkozar domenkozar Awaiting requested review from domenkozar

@ebzzry ebzzry Awaiting requested review from ebzzry

Assignees
No one assigned
Labels
2.status: merge conflict 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deluge: enable tests
1 participant
@SuperSandro2000