Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libtorrentRasterbar: rename to libtorrent-rasterbar, move around some files #107256

Merged
3 commits merged into from Dec 20, 2020
Merged

libtorrentRasterbar: rename to libtorrent-rasterbar, move around some files #107256

3 commits merged into from Dec 20, 2020

Conversation

ghost
Copy link

@ghost ghost commented Dec 20, 2020

Motivation for this change

This PR implements the changes requested in #107194 (comment) with the exception of making one version of libtorrent-rasterbar an override of another version. This is because libtorrent 1.1.x can be removed soon and libtorrent 1.2.x and 2.0.x are packaged very differently.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Milan Pässler added 3 commits December 20, 2020 15:51
No other packages have an own directory for each version with only one
file in each directory.
No other packages have an own directory for each version with only one
file in each directory.
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. +1 for removing the useless version subdirectories.

@ghost ghost merged commit a333985 into NixOS:master Dec 20, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant