Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eclipses: 2020-09 -> 2020-12 and add eclipse-rust #107260

Closed
wants to merge 2 commits into from
Closed

eclipses: 2020-09 -> 2020-12 and add eclipse-rust #107260

wants to merge 2 commits into from

Conversation

mohe2015
Copy link
Contributor

@mohe2015 mohe2015 commented Dec 20, 2020 •
edited

Motivation for this change

eclipse got an update and Rust is a popular language.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mohe2015 mohe2015 requested a review from rycee as a code owner December 20, 2020 15:23
@rycee
Copy link
Member

rycee commented Dec 20, 2020

Thanks! Rebased to master in 56b0eb0.

@rycee rycee closed this Dec 20, 2020
@mohe2015 mohe2015 deleted the more-eclipses branch December 20, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rycee rycee Awaiting requested review from rycee

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mohe2015 @rycee