Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] steam/fhsenv: Add LD_LIBRARY_PATH (and hence OpenGL driver library path) to output of --print-steam-runtime-library-paths #107252

Merged
merged 1 commit into from Dec 20, 2020
Merged

[20.09] steam/fhsenv: Add LD_LIBRARY_PATH (and hence OpenGL driver library path) to output of --print-steam-runtime-library-paths #107252

merged 1 commit into from Dec 20, 2020

Conversation

1000101
Copy link
Member

@1000101 1000101 commented Dec 20, 2020 •
edited

Motivation for this change

Backport of #106843.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tested on stable with: DoD: Source, L4D2, Civilization V

@1000101 1000101 changed the title steam/fhsenv: Add LD_LIBRARY_PATH (and hence OpenGL driver library pa… [20.09] steam/fhsenv: Add LD_LIBRARY_PATH (and hence OpenGL driver library path) to output of --print-steam-runtime-library-paths Dec 20, 2020
@prusnak
Copy link
Member

prusnak commented Dec 20, 2020 •
edited

Please cherry pick from master using git cherry-pick -x so the commit message contains the reference to the original commit (see CONTRIBUTING.md where this is described).

@jbalme @1000101
steam/fhsenv: Add LD_LIBRARY_PATH (and hence OpenGL driver library pa…
f3d651e 
…th) to output of --print-steam-runtime-library-paths

(cherry picked from commit 0127c29)
@1000101
Copy link
Member Author

1000101 commented Dec 20, 2020

Please cherry pick from master using git cherry-pick -x so the commit message contains the reference to the original commit (see CONTRIBUTING.md where this is described).

Fixed, thanks.

@1000101 1000101 mentioned this pull request Dec 20, 2020
Merged
10 tasks
@Atemu Atemu requested a review from jonringer December 20, 2020 13:13
@mmahut mmahut merged commit 3d2d8f2 into NixOS:release-20.09 Dec 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: steam 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@1000101 @prusnak @mmahut @jbalme