Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

foot: 1.5.1 -> 1.6.2 #107265

Merged
merged 1 commit into from Dec 31, 2020
Merged

foot: 1.5.1 -> 1.6.2 #107265

merged 1 commit into from Dec 31, 2020

Conversation

sternenseemann
Copy link
Member

Motivation for this change

Changelog

  • fix build with clangStdenv
  • support foot's PGO build
    • enable by default if gcc is used (there are some unresolved warnings
      with clang which need to investigated if they are detrimental, but
      it works all in all)
    • build should be deterministic with PGO as we use an input file which
      is generated with the same seed everytime.
  • apply nixpkgs-fmt
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Supersedes #106529.

@sternenseemann
Copy link
Member Author

Seems like using a fixed seed for input generation does the trick in terms of deterministic build outputs: I was able to get the exact same build result for gcc PGO build on two different x86_64 machines.

@sternenseemann sternenseemann force-pushed the foot-1.6.0 branch 2 times, most recently from 132cf3f to 0477715 Compare December 20, 2020 20:25
@sternenseemann
Copy link
Member Author

Fixed the PGO build for clang as well, now enabled by default for all compilers.

@sternenseemann sternenseemann changed the title foot: 1.5.1 -> 1.6.0 foot: 1.5.1 -> 1.6.1 Dec 21, 2020
@sternenseemann
foot: 1.5.1 -> 1.6.2
ec5f50d 
* fix build with clangStdenv
* support foot's PGO build
  * enable by default
  * build should be deterministic with PGO as we use an input file which
    is generated with the same seed everytime.
* apply nixpkgs-fmt
@sternenseemann sternenseemann changed the title foot: 1.5.1 -> 1.6.1 foot: 1.5.1 -> 1.6.2 Dec 21, 2020
@sternenseemann
Copy link
Member Author

@GrahamcOfBorg build foot

@WolfangAukang
Copy link
Contributor

WolfangAukang commented Dec 29, 2020 •
edited

Result of nixpkgs-review pr 107265 run on x86_64-linux 1

1 package built:
  • foot

Working fine for me

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/310

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107265 run on x86_64-linux 1

1 package built:
  • foot

@nh2 nh2 merged commit 3658b40 into NixOS:master Dec 31, 2020
@sternenseemann sternenseemann deleted the foot-1.6.0 branch December 31, 2020 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sternenseemann @WolfangAukang @nixos-discourse @SuperSandro2000 @nh2