notsodeep: init at 2019.5.29 #107254
Closed
notsodeep: init at 2019.5.29 #107254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding notsodeep which is an utility for active DPI circumvention. the version number is last commit date of notsodeep repository.
prusnak
requested changes
Dec 20, 2020
Comment on lines
+1
to
+3
| { pkgs, stdenv, fetchFromGitHub }: | ||
| with stdenv; | ||
| mkDerivation { |
There was a problem hiding this comment.
Suggested change
| { pkgs, stdenv, fetchFromGitHub }: | |
| with stdenv; | |
| mkDerivation { | |
| { stdenv, fetchFromGitHub }: | |
| stdenv.mkDerivation rec { |
Comment on lines
+4
to
+7
| # notsodeep doesn't have version number | ||
| # So I added last commit date instead | ||
| pname = "notsodeep"; | ||
| version = "2019.5.29"; |
There was a problem hiding this comment.
Suggested change
| # notsodeep doesn't have version number | |
| # So I added last commit date instead | |
| pname = "notsodeep"; | |
| version = "2019.5.29"; | |
| pname = "notsodeep"; | |
| version = "unstable-2019-05-29"; |
| version = "2019.5.29"; | ||
| src = fetchFromGitHub { | ||
| owner = "farukuzun"; | ||
| repo = "notsodeep"; |
There was a problem hiding this comment.
Suggested change
| repo = "notsodeep"; | |
| repo = pname; |
| sha256 = "0rzxszvjcv86516cv79zxs65jvd464483y6xv9g6l0bhjvrdr9kv"; | ||
| }; | ||
|
|
||
| buildInputs = with pkgs; [ libnetfilter_queue libnfnetlink ]; |
There was a problem hiding this comment.
Suggested change
| buildInputs = with pkgs; [ libnetfilter_queue libnfnetlink ]; | |
| buildInputs = [ libnetfilter_queue libnfnetlink ]; |
| mkdir -p $out/bin | ||
| cp notsodeep $out/bin | ||
| ''; | ||
| meta = with lib; { |
There was a problem hiding this comment.
Suggested change
| meta = with lib; { | |
| meta = with stdenv.lib; { |
| description = "Active DPI circumvention utility for Linux"; | ||
| homepage = "https://github.com/farukuzun/notsodeep"; | ||
| license = licenses.asl20; | ||
| maintainers = [ maintainers.damhiya ]; |
There was a problem hiding this comment.
Suggested change
| maintainers = [ maintainers.damhiya ]; | |
| maintainers = with maintainers; [ damhiya ]; |
| @@ -699,6 +699,8 @@ in | |||
|
|
|||
| albert = libsForQt5.callPackage ../applications/misc/albert {}; | |||
|
|
|||
| notsodeep = callPackage ../tools/networking/notsodeep { }; | |||
There was a problem hiding this comment.
Put this below in the file, so the packages are alphabetically sorted.
Okay, I can't assure the safety of the package to other people, and maybe it was not appropriate to register unmaintained software on nixpkgs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
notsodeepis an active DPI circumvention utility.Here is the original repository : https://github.com/farukuzun/notsodeep
I wrote a nix expression for
notsodeepand it seems it works well.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)