Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/nextcloud: fix missing quotes arround $* in occ wrapper and replace with $@ #107267

Merged
merged 1 commit into from Dec 24, 2020
Merged

nixos/nextcloud: fix missing quotes arround $* in occ wrapper and replace with $@ #107267

merged 1 commit into from Dec 24, 2020

Conversation

beardhatcode
Copy link
Contributor

@beardhatcode beardhatcode commented Dec 20, 2020 •
edited

This will allow this to work:
nextcloud-occ config:app:set theming slogan --value="A place for testing"

Motivation for this change

nextcloud-occ config:app:set theming slogan --value="A place for testing" fails

nextcloud-occ config:app:set theming slogan --value="A place for testing" gives an error

$* → config:app:set theming slogan --value=A place for testing
"$@" → config:app:set theming slogan --value=A place for testing

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date (no changes needed)
  • Fits CONTRIBUTING.md.

@beardhatcode beardhatcode changed the title nixos/nextcloud: fix missing quotes arround $* in occ wrapper and nixos/nextcloud: fix missing quotes arround $* in occ wrapper and replace with $@ Dec 20, 2020
@beardhatcode
nixos/nextcloud: fix missing quotes arround $* in occ wrapper and rep…
9bc704a 
…lace with $@

This will allow this to work:
    nextcloud-occ config:app:set theming slogan --value="A place for testing"
@bjornfor bjornfor merged commit caa725a into NixOS:master Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@beardhatcode @bjornfor