Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ncmpcpp: 0.8.2 -> 0.9.1 #107480

Merged
merged 1 commit into from Dec 25, 2020
Merged

ncmpcpp: 0.8.2 -> 0.9.1 #107480

merged 1 commit into from Dec 25, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 23, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from jfrankenau December 23, 2020 16:47
SuperSandro2000
SuperSandro2000 reviewed Dec 23, 2020
View reviewed changes
pkgs/applications/audio/ncmpcpp/default.nix

src = fetchurl {
url = "https://ncmpcpp.rybczak.net/stable/${pname}-${version}.tar.bz2";
sha256 = "0m0mjb049sl62vx13h9waavysa30mk0rphacksnvf94n13la62v5";
url = "https://rybczak.net/ncmpcpp/stable/${pname}-${version}.tar.bz2";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we not fetching from github?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it would require running autoconf stuff.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107480 run on x86_64-darwin 1

1 package built:
  • ncmpcpp

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107480 run on x86_64-linux 1

1 package built:
  • ncmpcpp

@doronbehar doronbehar merged commit 57e9cb9 into NixOS:master Dec 25, 2020
@marsam marsam deleted the update-ncmpcpp branch May 31, 2023 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@doronbehar doronbehar doronbehar approved these changes

@jfrankenau jfrankenau Awaiting requested review from jfrankenau

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @SuperSandro2000 @doronbehar