Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] brave: 1.17.73 -> 1.18.75 #107542

Merged
merged 3 commits into from Dec 25, 2020
Merged

[20.09] brave: 1.17.73 -> 1.18.75 #107542

merged 3 commits into from Dec 25, 2020

Conversation

buckley310
Copy link
Contributor

@buckley310 buckley310 commented Dec 24, 2020 •
edited

Motivation for this change

Backport #107523

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

nasirhm and others added 2 commits December 24, 2020 10:54
@nasirhm @buckley310
brave: version updated: 1.16.76 -> 1.17.73
a7daa0f 
Version updated for Brave Browser from 1.16.76 to 1.17.73:

- Added a dependency for libxkbcommon.
- Updated SHA256 for the version bumped brave browser.

Signed-off-by: nasirhm <nasirhussainm14@gmail.com>
(cherry picked from commit 1f6d64d)
@buckley310
brave: 1.17.73 -> 1.18.70
0977754 
(cherry picked from commit 41c2040)
@ofborg ofborg bot requested review from rht and uskudnik December 24, 2020 16:41
@prusnak
Copy link
Member

prusnak commented Dec 24, 2020

Please also cherry-pick commit 156ce8d from #107523

@buckley310
brave: 1.18.70 -> 1.18.75
d239849 
(cherry picked from commit 156ce8d)
@buckley310 buckley310 changed the title [20.09] brave: 1.17.73 -> 1.18.70 [20.09] brave: 1.17.73 -> 1.18.75 Dec 24, 2020
@buckley310
Copy link
Contributor Author

Done. Thanks 👍

@doronbehar doronbehar merged commit ae1b121 into NixOS:release-20.09 Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@rht rht Awaiting requested review from rht

@uskudnik uskudnik Awaiting requested review from uskudnik

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@buckley310 @prusnak @doronbehar @nasirhm