Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/systemd: provide libidn2 for systemd-resolved #107572

Merged
merged 1 commit into from Dec 25, 2020
Merged

nixos/systemd: provide libidn2 for systemd-resolved #107572

merged 1 commit into from Dec 25, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Dec 25, 2020

systemd started using dlopen() for some of their "optional"
dependencies.

Apparently, libidn2 isn't so optional, and systemd-resolved doesn't
work without libidn2 present, breaking DNS resolution.

Fixes #107537

Upstream bug: systemd/systemd#18078

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
nixos/systemd: provide libidn2 for systemd-resolved
c674a51 
systemd started using dlopen() for some of their "optional"
dependencies.

Apparently, `libidn2` isn't so optional, and systemd-resolved doesn't
work without libidn2 present, breaking DNS resolution.

Fixes NixOS#107537

Upstream bug: systemd/systemd#18078
@flokli flokli requested a review from vcunat December 25, 2020 12:47
@flokli flokli mentioned this pull request Dec 25, 2020
Closed
jpotier
jpotier approved these changes Dec 25, 2020
View reviewed changes
Copy link
Contributor

@jpotier jpotier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested a similar change locally, with success.

@xaverdh
Copy link
Contributor

xaverdh commented Dec 25, 2020

My system is running on unstable-small + this pr now. I can confirm that DNS works again.

@jpotier
Copy link
Contributor

jpotier commented Dec 25, 2020

I've also rebuild my whole system against flokli:nixos-fix-resolved, and without my local fix, DNS works 👍

@flokli flokli merged commit be0b453 into NixOS:master Dec 25, 2020
@flokli flokli deleted the nixos-fix-resolved branch December 25, 2020 13:56
@flokli
Copy link
Contributor Author

flokli commented Dec 25, 2020

I kicked off a hydra evaluation, so this hopefully ends up in the channels soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpotier jpotier jpotier approved these changes

@vcunat vcunat Awaiting requested review from vcunat

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DNS broke for most programs after recent update on the nixos-unstable channel
3 participants
@flokli @xaverdh @jpotier