Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox: 84.0.1 #107603

Merged
merged 3 commits into from Dec 28, 2020
Merged

firefox: 84.0.1 #107603

merged 3 commits into from Dec 28, 2020

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Dec 25, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from edolstra December 25, 2020 22:52
@mweinelt
Copy link
Member 

❯ nix-build -A firefox-wayland -A firefox -A firefox-bin -A firefox-beta-bin
/nix/store/0nk0jcxl4didqvp89g17g07qykn3hh69-firefox-84.0.1
/nix/store/inm6rfk93qw5pqi7ri38h9hsyynl59ih-firefox-84.0.1
/nix/store/mfwp4l6gdg783l65nv90yn595wixi8di-firefox-bin-84.0.1
/nix/store/v95fz27r9fp7qy9qbixfycj55lijzjm9-firefox-beta-bin-85.0b4

on x86_64-linux

Have been using firefox-wayland for a few hours and it LGTM.

@vcunat
Copy link
Member

vcunat commented Dec 27, 2020

Release notes: https://www.mozilla.org/en-US/firefox/84.0.1/releasenotes/
In particular, no security fixes, apparently.

vcunat
vcunat approved these changes Dec 28, 2020
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All three seem to work for me.

@vcunat vcunat merged commit 85c8f75 into NixOS:master Dec 28, 2020
@ajs124 ajs124 deleted the upd/firefox branch December 28, 2020 14:51
vcunat added a commit that referenced this pull request Jan 1, 2021
@vcunat
Merge #107603: firefox*: 84.0 -> 84.0.1
dfc86e4 
(cherry picked from commit 85c8f75)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@vcunat vcunat vcunat approved these changes

@taku0 taku0 Awaiting requested review from taku0

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajs124 @mweinelt @vcunat