Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

websocketpp: fix cross #107540

Merged
merged 1 commit into from Dec 24, 2020
Merged

websocketpp: fix cross #107540

merged 1 commit into from Dec 24, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Dec 24, 2020

Apparently, that's all needed to get websocketpp to cross-compile.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Apparently, that's all needed to get websocketpp to cross-compile.
@flokli flokli merged commit ae46445 into NixOS:master Dec 24, 2020
@flokli flokli deleted the websocketpp-fix-cross branch December 24, 2020 22:29
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107540 run on x86_64-darwin 1

1 package built:
  • websocketpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants