Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP [20.09] minecraft: 2.1.16102 -> 2.2.909 #107591

Closed
wants to merge 9 commits into from
Closed

WIP [20.09] minecraft: 2.1.16102 -> 2.2.909 #107591

wants to merge 9 commits into from

Conversation

redvers
Copy link
Member

@redvers redvers commented Dec 25, 2020

Motivation for this change

After several minecraft launcher bumps, mojang blocks the game from launching until update. This has resulted in the version in 20.09 failing to launch. This PR updates us to the latest version.

Things done

NOTE: What is NOT done - I'm away from my desktop at the moment so have no way to test this properly (as it's a graphical application. Hopefully either someone else can test it or I can test it when I get back to it in a few days.

Thanks.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

TredwellGit and others added 9 commits December 25, 2020 19:06
@TredwellGit @redvers
minecraft: 2.1.16102 -> 2.1.17417
897ca2d 
Launcher 2.1.15852 removed GConf dependency.

(cherry picked from commit d7ac5bd)
@TredwellGit @redvers
minecraft: 2.1.17417 -> 2.1.17627
0c29655 
(cherry picked from commit d458c00)
@TredwellGit @redvers
minecraft: 2.1.17627 -> 2.1.17785
684fb27 
(cherry picked from commit 5be1990)
@NeQuissimus @redvers
minecraft: Skip desktop file validation
b52a1dd 
(cherry picked from commit 0ce6c50)
@NeQuissimus @redvers
minecraft: Add test
9795b15 
(cherry picked from commit 0dc74a1)
@B4dM4n @redvers
minecraft: use copyDesktopItems hook
8aa0cc4 
(cherry picked from commit 81e2df3)
@TredwellGit @redvers
minecraft: 2.1.17785 -> 2.2.741
f39e2bb 
(cherry picked from commit 814df29)
@bjpbakker @redvers
minecraft: fix JAVA_HOME
feae760 
JAVA_HOME should point to the root directory of the JRE, not the `bin` folder.

(cherry picked from commit 0451efc)
@cpages @redvers
minecraft: 2.2.741 -> 2.2.909
1f272ea 
(cherry picked from commit f1f9a55)
@SuperSandro2000 SuperSandro2000 changed the title Update minecraft [20.09] minecraft: 2.1.16102 -> 2.2.909 Dec 25, 2020
@redvers
Copy link
Member Author

redvers commented Dec 25, 2020

@GrahamcOfBorg test minecraft

@redvers redvers changed the title [20.09] minecraft: 2.1.16102 -> 2.2.909 WIP [20.09] minecraft: 2.1.16102 -> 2.2.909 Dec 25, 2020
@redvers
Copy link
Member Author

redvers commented Dec 25, 2020

Ah, I see why this failed. A change in copyDesktopItems - this can't be directly cherry-picked. Putting on hold, will revisit shortishly.

@redvers
Copy link
Member Author

redvers commented Jun 5, 2021

Stale, old, can go away.

@redvers redvers closed this Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@redvers @TredwellGit @NeQuissimus @B4dM4n @bjpbakker @cpages