Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab: 13.6.1 -> 13.7.1 #107558

Merged
1 commit merged into from Dec 26, 2020
Merged

gitlab: 13.6.1 -> 13.7.1 #107558

1 commit merged into from Dec 26, 2020

Conversation

jslight90
Copy link
Contributor

Motivation for this change

Update to the latest release of GitLab.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 reviewed Dec 25, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you where using an older version of vgo2nix. Could you regenerate the files with the newest version?

@jslight90
Copy link
Contributor Author

jslight90 commented Dec 25, 2020 •
edited

I think you where using an older version of vgo2nix. Could you regenerate the files with the newest version?

I'm adding the changes using the new version from c60ef6a.

@ghost ghost merged commit e86efbc into NixOS:master Dec 26, 2020
@ghost
Copy link

ghost commented Dec 26, 2020

Tested: Upgrade from 13.6.1, created a repository, cloned a repository, pushed to a repository, edited a file in the web editor, created a MR and merged it.

@ghost ghost mentioned this pull request Dec 26, 2020
Closed
10 tasks
ghost pushed a commit that referenced this pull request Dec 26, 2020
gitlab: remove unused deps.nix files
3157904 
These were added again in #107558
because the update script still ran vgo2nix.
@jslight90 jslight90 deleted the gitlab-13.7 branch December 28, 2020 19:19
@jslight90
Copy link
Contributor Author

After upgrading one of our gitlab servers, I had to flush the feature_flag configuration files before the gitlab service would start:
rm -rf /var/gitlab/state/config/feature_flags/*

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@talyz talyz Awaiting requested review from talyz

@kalbasit kalbasit Awaiting requested review from kalbasit

@fpletz fpletz Awaiting requested review from fpletz

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jslight90 @SuperSandro2000