Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yj: 4.0.0 -> 5.0.0 #107484

Merged
merged 1 commit into from Dec 25, 2020
Merged

yj: 4.0.0 -> 5.0.0 #107484

merged 1 commit into from Dec 25, 2020

Conversation

nightmared
Copy link
Contributor

Motivation for this change

This PR is necessary to advance cargo2nix/cargo2nix#165
(older versions of yj didn't differenciate between integers and floats,
which can break cargo manifests when converting from TOML to JSON and back).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from Profpatsch and kalbasit December 23, 2020 17:46
@nightmared
yj: 4.0.0 -> 5.0.0
2a9b003 
Necessary to advance cargo2nix/cargo2nix#165
(older versions of yj didn't differenciate between integers and floats,
which can break cargo manifests when converting from TOML to JSON and back).
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107484 run on x86_64-darwin 1

2 packages built:
  • poetry
  • yj

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107484 run on x86_64-linux 1

2 packages built:
  • poetry
  • yj

@SuperSandro2000 SuperSandro2000 merged commit 4c0f6b3 into NixOS:master Dec 25, 2020
@nightmared nightmared deleted the yj-5.0.0 branch December 25, 2020 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@Profpatsch Profpatsch Awaiting requested review from Profpatsch

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nightmared @SuperSandro2000 @Janik-Haag