Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

epkowa: add support for 'Perfection V37/V370' scanners #107584

Merged
merged 2 commits into from Dec 25, 2020
Merged

epkowa: add support for 'Perfection V37/V370' scanners #107584

merged 2 commits into from Dec 25, 2020

Conversation

nek0
Copy link
Contributor

@nek0 nek0 commented Dec 25, 2020

Motivation for this change

Scanner support for the model I own was missing.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from symphorien December 25, 2020 17:01
SuperSandro2000
SuperSandro2000 reviewed Dec 25, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor nitpick. I wish you a merry Christmas, nek0!

pkgs/misc/drivers/epkowa/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107584 run on x86_64-linux 1

1 package built:
  • epkowa

@nek0
Copy link
Contributor Author

nek0 commented Dec 25, 2020

Since this fact is not covered by the standard "what has been done" questions: The output of the package has been tested with said scanner and it's working.

@SuperSandro2000 SuperSandro2000 merged commit 357e070 into NixOS:master Dec 25, 2020
@nek0 nek0 deleted the epson_perfection_v37 branch December 25, 2020 20:11
@lenzj lenzj mentioned this pull request Mar 21, 2021
Closed
10 tasks
@lenzj lenzj mentioned this pull request May 14, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@symphorien symphorien Awaiting requested review from symphorien

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nek0 @SuperSandro2000