Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify GUI to search server on internet or LAN #8426

Merged
merged 2 commits into from Dec 24, 2020
Merged

Simplify GUI to search server on internet or LAN #8426

merged 2 commits into from Dec 24, 2020

Conversation

frosch123
Copy link
Member

@frosch123 frosch123 commented Dec 24, 2020 •
edited

Motivation / Problem

Currently the server list has a button "find servers" at the bottom. Its behavior depends on an "advertised: yes/no" combobox at the top of the window.

  • It's non-obvious that these two GUI elements are related.
  • The combobox has no other effect.
  • The strings are shared with the "start server" window. While they fit there, the wording is weird for the server list.

Description

The interface is simplified:

  • The combobox is removed along with its setting that remembered the selection.
  • The "find server" button is split into two buttons to search on internet or on LAN.

Limitations

This PR reorders some strings in english.txt. Eints will do this for the other languages.

Checklist for review

N/A

@TrueBrain TrueBrain added candidate: yes This Pull Request is a candidate for being merged preview This PR is receiving preview builds size: small This Pull Request is small, and should be relative easy to process labels Dec 24, 2020
@DorpsGek DorpsGek temporarily deployed to preview-pr-8426 December 24, 2020 19:18 Inactive
TrueBrain
TrueBrain requested changes Dec 24, 2020
View reviewed changes
Copy link
Member

@TrueBrain TrueBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

You forgot to either move the box down with the space you created, or make it bigger, I think :)
It used to look like this:

image

src/lang/english.txt Outdated Show resolved Hide resolved
@DorpsGek DorpsGek temporarily deployed to preview-pr-8426 December 24, 2020 20:04 Inactive
TrueBrain
TrueBrain approved these changes Dec 24, 2020
View reviewed changes
Copy link
Member

@TrueBrain TrueBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such pretty! And really an improvement, might I add :)

@michicc michicc merged commit ba49fa3 into OpenTTD:master Dec 24, 2020
@TrueBrain TrueBrain mentioned this pull request Dec 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrueBrain TrueBrain TrueBrain approved these changes

Assignees
No one assigned
Labels
candidate: yes This Pull Request is a candidate for being merged preview This PR is receiving preview builds size: small This Pull Request is small, and should be relative easy to process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@frosch123 @TrueBrain @michicc @DorpsGek