Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kakoune: fix installCheck #107383

Merged
merged 1 commit into from Dec 24, 2020
Merged

kakoune: fix installCheck #107383

merged 1 commit into from Dec 24, 2020

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Dec 22, 2020

  • doInstallCheckPhase -> doInstallCheck
  • -E throws an exception that is uncaught, leading the check to fail.
    -e works as expected.
Motivation for this change

Was just looking at the derivation for its dependencies to make a shell.nix for hacking on kakoune, and noticed these two oddities.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cole-h
kakoune: fix installCheck
9b3fe2e 
* `doInstallCheckPhase` -> `doInstallCheck`
* `-E` throws an exception that is uncaught, leading the check to fail.
`-e` works as expected.
@ofborg ofborg bot requested a review from vrthra December 22, 2020 10:17
drewrisinger
drewrisinger approved these changes Dec 24, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Commit LGTM
  • Builds via nix-review
  • Runs in terminal. Set a weird color scheme by default, but that might be some weird bug with my terminal (on VSCode/WSL), not had this w/ kak before.
https://github.com/NixOS/nixpkgs/pull/107383

2 packages built:
kakoune kakoune-unwrapped

@Lassulus Lassulus merged commit 16b8010 into NixOS:master Dec 24, 2020
@cole-h cole-h deleted the kakoune branch December 24, 2020 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewrisinger drewrisinger drewrisinger approved these changes

@vrthra vrthra Awaiting requested review from vrthra

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cole-h @drewrisinger @Lassulus