Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 46ceea466691
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 16b80104bff1
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Dec 22, 2020

  1. kakoune: fix installCheck

    * `doInstallCheckPhase` -> `doInstallCheck`
    * `-E` throws an exception that is uncaught, leading the check to fail.
    `-e` works as expected.
    cole-h committed Dec 22, 2020

    Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    cole-h Cole Helbling
    Copy the full SHA
    9b3fe2e View commit details

Commits on Dec 24, 2020

  1. Merge pull request #107383 from cole-h/kakoune

    kakoune: fix installCheck
    Lassulus authored Dec 24, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    16b8010 View commit details
Showing with 2 additions and 2 deletions.
  1. +2 −2 pkgs/applications/editors/kakoune/default.nix
4 changes: 2 additions & 2 deletions pkgs/applications/editors/kakoune/default.nix
Original file line number Diff line number Diff line change
@@ -25,9 +25,9 @@ stdenv.mkDerivation rec {
export version="v${version}"
'';

doInstallCheckPhase = true;
doInstallCheck = true;
installCheckPhase = ''
$out/bin/kak -ui json -E "kill 0"
$out/bin/kak -ui json -e "kill 0"
'';

postInstall = ''