Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xfsprogs: 4.19 -> 5.10 #107597

Merged
merged 1 commit into from Jan 2, 2021
Merged

xfsprogs: 4.19 -> 5.10 #107597

merged 1 commit into from Jan 2, 2021

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Dec 25, 2020

Motivation for this change

xfsprogs was outdated by several years and does not appear to have an (active) maintainer.

Closes #107010

cc @TredwellGit @Mic92

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lovesegfault
Copy link
Member

Seems like this should target staging?

@ajs124
Copy link
Member Author

ajs124 commented Dec 25, 2020

ofborg says <500 rebuilds, so I guess it should be fine?

Copy link
Member

@TredwellGit TredwellGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think #107010 is better for inih.

sha256 = "0lsvm34zabvi1xlximybzvgc58zb90mm3b9babwxlqs05jy871m4";
};

mesonFlags = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove "-Dwith_INIReader=true"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It only occured to me to search the tracker for xfsprogs after I already did all these things, but I can incorporate your changes.

];

meta = with stdenv.lib; {
homepage = "";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove the homepage and changelog?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As explained above, I didn't remove them, I just did not add them.

homepage = "";
description = "A simple .INI file parser written in C";
license = licenses.bsd3;
platforms = platforms.linux;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why platforms.linux instead of platforms.all?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I can't test anything else and I therefore cannot support them as a maintainer.

@ajs124
Copy link
Member Author

ajs124 commented Dec 25, 2020

@TredwellGit we can also merge #107010 and I can rebase on that, but it should have a maintainer.

@TredwellGit
Copy link
Member

Let me add myself as a maintainer.

@lovesegfault
Copy link
Member

Result of nixpkgs-review pr 107597 run on x86_64-linux 1

5 packages marked as broken and skipped:
  • bareos
  • gnome3.gnome-books
  • gnome3.gnome-documents
  • xmonad_log_applet
  • xmonad_log_applet_gnome3
2 packages failed to build:
  • samba4Full
  • scylladb
122 packages built:
  • adapta-gtk-theme
  • almanah
  • atom
  • atom-beta
  • bubblemail
  • calls
  • cantata
  • ceph
  • ceph-client
  • charliecloud
  • chrome-gnome-shell
  • cinnamon.cinnamon-common
  • cinnamon.cinnamon-control-center
  • cinnamon.cinnamon-gsettings-overrides
  • cinnamon.cinnamon-screensaver
  • clementine
  • clementineUnfree
  • disnix
  • disnixos
  • docker
  • docker-gc
  • docker_18_09
  • dropbox-cli
  • dydisnix
  • dysnomia
  • elementary-planner
  • empathy
  • enlightenment.enlightenment
  • evolution-data-server (evolution_data_server)
  • evolution-ews
  • far2l
  • feedreader
  • folks
  • gfbgraph
  • glusterfs
  • gnome-multi-writer
  • gnome-online-accounts
  • gnome-photos
  • gnome-recipes
  • gnome2.gvfs
  • gnome3.bijiben
  • gnome3.cheese
  • gnome3.evolution
  • gnome3.file-roller
  • gnome3.geary
  • gnome3.gnome-applets
  • gnome3.gnome-boxes
  • gnome3.gnome-calendar
  • gnome3.gnome-contacts
  • gnome3.gnome-control-center
  • gnome3.gnome-disk-utility
  • gnome3.gnome-flashback
  • gnome3.gnome-initial-setup
  • gnome3.gnome-maps
  • gnome3.gnome-music
  • gnome3.gnome-online-miners
  • gnome3.gnome-panel
  • gnome3.gnome-session
  • gnome3.gnome-shell
  • gnome3.gnome-software
  • gnome3.gnome-terminal
  • gnome3.gnome-todo
  • gnome3.gnome-tweak-tool
  • gnome3.gnome-user-share
  • gnome3.grilo-plugins
  • gnome3.gvfs
  • gnome3.libgdata
  • gnome3.libzapojit
  • gnome3.nautilus
  • gnome3.nautilus-python
  • gnome3.pomodoro
  • gnome3.shotwell
  • gnome3.totem
  • gnome3.tracker-miners
  • gnomeExtensions.easyScreenCast
  • gnomeExtensions.gsconnect
  • gnomeExtensions.night-theme-switcher
  • hal-flash
  • libceph
  • libguestfs
  • libguestfs-with-appliance
  • libinih
  • libvmi
  • libxfs
  • mailnagWithPlugins
  • mate.mate-utils
  • nfs-ganesha
  • out-of-tree
  • pantheon.elementary-calendar
  • pantheon.elementary-greeter
  • pantheon.elementary-session-settings
  • pantheon.extra-elementary-contracts
  • pantheon.wingpanel-indicator-datetime
  • pantheon.wingpanel-with-indicators
  • pipework
  • psensor
  • python37Packages.guestfs
  • python37Packages.jupyter-repo2docker
  • python38Packages.guestfs
  • python38Packages.jupyter-repo2docker
  • python39Packages.guestfs
  • python39Packages.jupyter-repo2docker
  • qemu_xen (qemu_xen_4_10)
  • qubes-core-vchan-xen
  • rabbitvcs
  • rapid-photo-downloader
  • spaceFM
  • udiskie
  • udisks
  • usermount
  • vagrant
  • vifm-full
  • xen
  • xen-slim
  • xfce.gigolo
  • xfce.gvfs
  • xfce.thunar (xfce.thunar-bare)
  • xfce.thunar-archive-plugin
  • xfce.thunar-dropbox-plugin
  • xfce.xfdesktop
  • xfsprogs
  • xfstests

@TredwellGit
Copy link
Member

Okay, please merge #107010 then rebase.

@ajs124
Copy link
Member Author

ajs124 commented Dec 25, 2020

@TredwellGit done

@lovesegfault I'll see if I can figure out what's happening with samba4Full (and scylladb). Are they actually working on master?

@lovesegfault
Copy link
Member

@TredwellGit done

@lovesegfault I'll see if I can figure out what's happening with samba4Full (and scylladb). Are they actually working on master?

Let me check

@lovesegfault
Copy link
Member

@TredwellGit done
@lovesegfault I'll see if I can figure out what's happening with samba4Full (and scylladb). Are they actually working on master?

Let me check

Both are broken in master.

@ajs124
Copy link
Member Author

ajs124 commented Dec 25, 2020

@TredwellGit done
@lovesegfault I'll see if I can figure out what's happening with samba4Full (and scylladb). Are they actually working on master?

Let me check

Both are broken in master.

That's good. I mean, it isn't, but that means that this PR is not at fault.

I'll leave this open, in case anyone wants to review it or has any objections, e.g. if we should ship a newer xfsprogs than our current default kernel release or something like that.

In case no-one requests any changes, I'll merge this in 7 days (in my timezone), so on 2021-01-02. Feel free to merge it before that, but seeing as this hasn't been updated since December of 2018, there's probably no need to rush.

@ajs124
Copy link
Member Author

ajs124 commented Jan 2, 2021

After asking upstream, I think we should add a release notes entry to this, which I will write and push shortly.

@SuperSandro2000
Copy link
Member

@ofborg eval

@ajs124 ajs124 merged commit e78177e into NixOS:master Jan 2, 2021
@ajs124 ajs124 deleted the upd/xfsprogs branch January 2, 2021 22:55
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107597 run on x86_64-linux 1

3 packages marked as broken and skipped:
  • gnome3.gnome-books
  • gnome3.gnome-documents
  • xmonad_log_applet
2 packages blacklisted:
  • tests.nixos-functions.nixos-test
  • tests.nixos-functions.nixosTest-test
117 packages built:
  • adapta-gtk-theme
  • almanah
  • atom
  • atom-beta
  • bubblemail
  • calls
  • cantata
  • charliecloud
  • chrome-gnome-shell
  • cinnamon.cinnamon-common
  • cinnamon.cinnamon-control-center
  • cinnamon.cinnamon-gsettings-overrides
  • cinnamon.cinnamon-screensaver
  • clementine
  • clementineUnfree
  • disnix
  • disnixos
  • docker (docker-edge ,docker_19_03)
  • docker-gc
  • docker_18_09
  • dropbox-cli
  • dydisnix
  • dysnomia
  • elementary-planner
  • empathy (gnome3.empathy)
  • enlightenment.enlightenment
  • evolution-data-server (gnome3.evolution-data-server ,gnome3.evolution_data_server)
  • evolution-ews
  • far2l
  • feedreader
  • folks (gnome3.folks)
  • gfbgraph (gnome3.gfbgraph)
  • glusterfs
  • gnome-multi-writer
  • gnome-online-accounts (gnome3.gnome-online-accounts ,gnome3.gnome_online_accounts)
  • gnome-photos (gnome3.gnome-photos)
  • gnome-recipes
  • gvfs (gnome2.gvfs)
  • gnome3.bijiben (gnome3.gnome-notes)
  • gnome3.cheese
  • gnome3.evolution
  • gnome3.file-roller
  • gnome3.geary
  • gnome3.gnome-applets
  • gnome3.gnome-boxes
  • gnome3.gnome-calendar
  • gnome3.gnome-contacts
  • gnome3.gnome-control-center (gnome3.gnome_control_center)
  • gnome3.gnome-disk-utility
  • gnome3.gnome-flashback
  • gnome3.gnome-initial-setup
  • gnome3.gnome-maps
  • gnome3.gnome-music
  • gnome3.gnome-online-miners
  • gnome3.gnome-panel
  • gnome3.gnome-session (gnome3.gnome_session)
  • gnome3.gnome-shell (gnome3.gnome_shell)
  • gnome3.gnome-software
  • gnome3.gnome-terminal (gnome3.gnome_terminal)
  • gnome3.gnome-todo
  • gnome3.gnome-tweaks (gnome3.gnome-tweak-tool)
  • gnome3.gnome-user-share
  • grilo-plugins (gnome3.grilo-plugins)
  • gnome3.gvfs
  • libgdata (gnome3.libgdata)
  • libzapojit (gnome3.libzapojit)
  • gnome3.nautilus
  • gnome3.nautilus-python
  • gnome3.pomodoro
  • shotwell (gnome3.shotwell)
  • gnome3.totem
  • tracker-miners (gnome3.tracker-miners)
  • gnomeExtensions.easyScreenCast
  • gnomeExtensions.gsconnect
  • gnomeExtensions.night-theme-switcher
  • hal-flash
  • libguestfs
  • libvmi
  • libxfs
  • mailnagWithPlugins
  • mate.mate-utils
  • nfs-ganesha
  • out-of-tree
  • pantheon.elementary-calendar
  • pantheon.elementary-greeter
  • pantheon.elementary-session-settings
  • pantheon.extra-elementary-contracts
  • pantheon.wingpanel-indicator-datetime
  • pantheon.wingpanel-with-indicators
  • pipework
  • psensor
  • python37Packages.guestfs
  • python37Packages.jupyter-repo2docker
  • python38Packages.guestfs
  • python38Packages.jupyter-repo2docker
  • python39Packages.guestfs
  • python39Packages.jupyter-repo2docker
  • qemu_xen (qemu_xen_4_10)
  • qubes-core-vchan-xen
  • rabbitvcs
  • rapid-photo-downloader
  • spaceFM
  • udiskie
  • udisks (udisks2)
  • usermount
  • vagrant
  • vifm-full
  • xen (xenPackages.xen-vanilla ,xenPackages.xen_4_10-vanilla ,xen_4_10)
  • xen-slim (xenPackages.xen-slim ,xenPackages.xen_4_10-slim ,xen_4_10-slim)
  • xfce.gigolo
  • xfce.gvfs
  • xfce.thunar (xfce.thunar-bare ,xfce.thunar-build ,xfce.thunarx-2-dev)
  • xfce.thunar-archive-plugin
  • xfce.thunar-dropbox-plugin
  • xfce.xfdesktop
  • xfsprogs
  • xfstests

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

bubblemail:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
mailnagWithPlugins:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python37Packages.guestfs:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python38Packages.guestfs:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python39Packages.guestfs:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants