New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xfsprogs: 4.19 -> 5.10 #107597
xfsprogs: 4.19 -> 5.10 #107597
Conversation
Seems like this should target staging? |
ofborg says <500 rebuilds, so I guess it should be fine? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think #107010 is better for inih.
sha256 = "0lsvm34zabvi1xlximybzvgc58zb90mm3b9babwxlqs05jy871m4"; | ||
}; | ||
|
||
mesonFlags = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you remove "-Dwith_INIReader=true"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It only occured to me to search the tracker for xfsprogs after I already did all these things, but I can incorporate your changes.
]; | ||
|
||
meta = with stdenv.lib; { | ||
homepage = ""; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you remove the homepage and changelog?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As explained above, I didn't remove them, I just did not add them.
homepage = ""; | ||
description = "A simple .INI file parser written in C"; | ||
license = licenses.bsd3; | ||
platforms = platforms.linux; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why platforms.linux
instead of platforms.all
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I can't test anything else and I therefore cannot support them as a maintainer.
@TredwellGit we can also merge #107010 and I can rebase on that, but it should have a maintainer. |
Let me add myself as a maintainer. |
Result of 5 packages marked as broken and skipped:
2 packages failed to build:
122 packages built:
|
Okay, please merge #107010 then rebase. |
@TredwellGit done @lovesegfault I'll see if I can figure out what's happening with samba4Full (and scylladb). Are they actually working on master? |
Let me check |
Both are broken in master. |
That's good. I mean, it isn't, but that means that this PR is not at fault. I'll leave this open, in case anyone wants to review it or has any objections, e.g. if we should ship a newer xfsprogs than our current default kernel release or something like that. In case no-one requests any changes, I'll merge this in 7 days (in my timezone), so on 2021-01-02. Feel free to merge it before that, but seeing as this hasn't been updated since December of 2018, there's probably no need to rush. |
After asking upstream, I think we should add a release notes entry to this, which I will write and push shortly. |
@ofborg eval |
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 3 packages marked as broken and skipped:
2 packages blacklisted:
117 packages built:
The following issues got detected with the above build packages. bubblemail: Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
|
Motivation for this change
xfsprogs was outdated by several years and does not appear to have an (active) maintainer.
Closes #107010
cc @TredwellGit @Mic92
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)