Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netease-music-tui: init at v0.1.2 #107560

Merged
merged 1 commit into from Dec 27, 2020
Merged

netease-music-tui: init at v0.1.2 #107560

merged 1 commit into from Dec 27, 2020

Conversation

Vonfry
Copy link
Member

@Vonfry Vonfry commented Dec 25, 2020 •
edited

Motivation for this change

New package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Details

closure size

/nix/store/agrz6qbrmc3fabrw9s2f3ihjzs6l7ncw-netease-music-tui-v0.1.2	   49127512

nixpkgs-review

1 package added:
netease-music-tui-v0.1.2

1 package built:
netease-music-tui

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107560 run on x86_64-linux 1

1 package built:
  • netease-music-tui

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107560 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • netease-music-tui

@Vonfry
Copy link
Member Author

Vonfry commented Dec 25, 2020

Result of nixpkgs-review pr 107560 run on x86_64-darwin 1

1 package marked as broken and skipped:

  • netease-music-tui

Should I remove darwin from platforms? The package supports it, but I haven't device to test it.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107560 run on x86_64-darwin 1
1 package marked as broken and skipped:

  • netease-music-tui

Should I remove darwin from platforms? The package supports it, but I haven't device to test it.

This simply means it can't be build on darwin because I think alsa is not available on there.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 107560 run on x86_64-linux 1

1 package built:
  • netease-music-tui

@SuperSandro2000 SuperSandro2000 merged commit d8197b2 into NixOS:master Dec 27, 2020
@Vonfry Vonfry deleted the init/netease-music-tui branch December 27, 2020 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Vonfry @SuperSandro2000