Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix f66baa44: index was off by one #8433

Merged
merged 1 commit into from Dec 25, 2020
Merged

Fix f66baa44: index was off by one #8433

merged 1 commit into from Dec 25, 2020

Conversation

TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Dec 25, 2020 •
edited

Motivation / Problem

Broke master. You could not select an AI from the GUI anymore.

Description

i++ in the 3rd part of a for() is post, not pre. Oops.

See f66baa4#diff-65e506358d200c3adbd2679e9f04fdb017459a79f08852173dd9fc5964859dbeL131 for the original code.

@TrueBrain
Fix f66baa4: index was off by one
9eca477 
i++ in the 3rd part of a for() is post, not pre. Oops.
glx22
glx22 approved these changes Dec 25, 2020
View reviewed changes
Copy link
Contributor

@glx22 glx22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oups

@TrueBrain TrueBrain merged commit e6e91a3 into OpenTTD:master Dec 25, 2020
@TrueBrain TrueBrain deleted the fix_off_by_one branch December 25, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glx22 glx22 glx22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TrueBrain @glx22