Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prusa-slicer: 2.2.0 -> 2.3.0 #107187

Merged
merged 1 commit into from Jan 18, 2021
Merged

prusa-slicer: 2.2.0 -> 2.3.0 #107187

merged 1 commit into from Jan 18, 2021

Conversation

Moredread
Copy link
Contributor

@Moredread Moredread commented Dec 19, 2020

Motivation for this change

Preparing for the coming 2.3.0 release, documenting/sharing what needs to change.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Moredread
Copy link
Contributor Author

cc @mweinelt @ArdaXi @baracoder @thorstenweber83 as you were interested in the previous PRs

@Moredread Moredread changed the title prusa-slicer: 2.2.0 -> 2.3.0-rc1 [wip] prusa-slicer: 2.2.0 -> 2.3.0-rc1 Dec 19, 2020
@Moredread Moredread marked this pull request as draft December 19, 2020 06:15
@Moredread Moredread changed the title [wip] prusa-slicer: 2.2.0 -> 2.3.0-rc1 prusa-slicer: 2.2.0 -> 2.3.0-rc1 Dec 19, 2020
@vojta001
Copy link
Contributor

vojta001 commented Jan 2, 2021

Builds fine for me, but throws assertion errors from time to time and some UI parts are broken. It is still RC1 though

@anna328p
Copy link
Member

v2.3.0 is out.

@Moredread
Copy link
Contributor Author

I've updated the PR to 2.3.0, which uses GTK3. I hope I got all new dependencies...

@Moredread Moredread marked this pull request as ready for review January 13, 2021 15:20
@ArdaXi
Copy link
Contributor

ArdaXi commented Jan 13, 2021

I was trying to get this working myself (I really wanted to try the monotonic infill) and these are much the same changes I made. I did also end up adding hicolor-icon-theme because it was complaining about it being missing in the logs, but I'm not sure if it being missing actually affects anything.

@Moredread Moredread changed the title prusa-slicer: 2.2.0 -> 2.3.0-rc1 prusa-slicer: 2.2.0 -> 2.3.0 Jan 13, 2021
@Moredread
Copy link
Contributor Author

I was trying to get this working myself (I really wanted to try the monotonic infill) and these are much the same changes I made. I did also end up adding hicolor-icon-theme because it was complaining about it being missing in the logs, but I'm not sure if it being missing actually affects anything.

I have hicolor-icon-theme in my home-managers packages, so I didn't see that. I've added it to our inputs though as at least some packages do add it to their inputs. Not sure if this correct though...

@ArdaXi
Copy link
Contributor

ArdaXi commented Jan 13, 2021

Isn't that the same argument as for wrapGAppsHook? That should also be unnecessary if the user's environment is set up properly, and it seems like NixOS has standardized on providing it. See discussion in #16285

@Moredread
Copy link
Contributor Author

Isn't that the same argument as for wrapGAppsHook? That should also be unnecessary if the user's environment is set up properly, and it seems like NixOS has standardized on providing it. See discussion in #16285

Thanks, I didn't know about that. :)

@vojta001
Copy link
Contributor

prusa-gcodeviewer binary is not built, but prusa-slicer expects it to be

@Moredread
Copy link
Contributor Author

prusa-gcodeviewer binary is not built, but prusa-slicer expects it to be

Thanks! :) I've also added a application menu entry.

@cab404
Copy link
Member

cab404 commented Jan 17, 2021

Result of nixpkgs-review pr 107187 run on x86_64-linux 1

2 packages built:
  • prusa-slicer
  • super-slicer

@cab404
Copy link
Member

cab404 commented Jan 17, 2021

Wow, their GUI looks nice in this update)
All functionality works, slicing and exporting doesn't crash like it does in SS 2.3 branches.

Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks like a nice improvement. Unfortunately the printer is too far away in these days, so no real world testing. I clicked a bit around and found no immediate issue.

pkgs/applications/misc/prusa-slicer/default.nix Outdated Show resolved Hide resolved
xorg.libX11
] ++ checkInputs;

doCheck = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@Moredread
Copy link
Contributor Author

prusa-slicer segfaults when opening a gcode file with File -> G-Code preview after launching prusa-gcodeviewer. Does anyone else see this?

@ofborg ofborg bot requested a review from cab404 January 17, 2021 16:23
@mweinelt
Copy link
Member

prusa-slicer segfaults when opening a gcode file with File -> G-Code preview after launching prusa-gcodeviewer. Does anyone else see this?

Can't reproduce. Works for me.

@vojta001
Copy link
Contributor

@Moredread It works for me. Can you, may be, share your GCODE with us?

@Moredread
Copy link
Contributor Author

Moredread commented Jan 18, 2021

Thanks for checking, I guess in that case it's an upstream issue or my setup. I'll post my gcode file later if I remember, but it shouldn't block this PR.

@Moredread
Copy link
Contributor Author

It now works, no idea what has changed overnight. XD

@mweinelt mweinelt merged commit deac117 into NixOS:master Jan 18, 2021
@mweinelt
Copy link
Member

Thanks @Moredread!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants