Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiscreteTrajectory2, second part of the implementation and tests #3155

Merged
merged 9 commits into from
Oct 17, 2021

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Oct 17, 2021

The "only" thing that remains is serialization.

#3136.

CHECK(!trajectory.empty());
// NOTE(phl): This check might be too strict, we might want to allow LT as the
// time comparison, and to adjust the first point of trajectory as needed.
// We'll see if the clients need that.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They probably do, the (asynchronous) prediction is not going to match the history.

Sorry, something went wrong.

@eggrobin eggrobin added the LGTM label Oct 17, 2021
@pleroy pleroy merged commit 084a342 into mockingbirdnest:Ondelette Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants