Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: refresh rate doesn't work with vsync #9614

Closed
YouYouTheBoxx opened this issue Oct 17, 2021 · 1 comment
Closed

[Bug]: refresh rate doesn't work with vsync #9614

YouYouTheBoxx opened this issue Oct 17, 2021 · 1 comment
Labels
bug Something isn't working priority: low This issue should be fixed but has either a low impact or is en edge-case

Comments

@YouYouTheBoxx
Copy link

YouYouTheBoxx commented Oct 17, 2021 •
edited

Version of OpenTTD

OpenTTD 12.0

Expected result

Fps have to lock to the choosen refresh rate.

Actual result

Fps are locked to 60Fps when using VSync either using a bigger refresh rate than 60 or a lower refresh rate too.

Steps to reproduce

Nothing special. Just make turn VSync ON and set a refresh rate upper than 60Hz or less than 60Hz too.
@TrueBrain TrueBrain changed the title [Bug]: [Bug]: refresh rate doesn't work with vsync Oct 17, 2021
@TrueBrain
Copy link
Member

Vsync locks the refresh-rate to the display (as that is what vsync means: go in sync with my display). So I do not think the bug is that the FPS doesn't change when vsync is on and you change the refresh-rate. I think the bug is you can change the refresh-rate when vsync is on. That shouldn't happen, I guess.

Something to investigate further, also in what is possible and not :)

@TrueBrain TrueBrain added bug Something isn't working priority: low This issue should be fixed but has either a low impact or is en edge-case labels Oct 17, 2021
LordAro added a commit to LordAro/OpenTTD that referenced this issue Oct 17, 2021
@LordAro
Fix OpenTTD#9614: Refresh rate dropdown was still active when vsync w…
e9970f4 
…as enabled
TrueBrain pushed a commit to TrueBrain/OpenTTD that referenced this issue Oct 23, 2021
@LordAro @TrueBrain
Fix OpenTTD#9614: Refresh rate dropdown was still active when vsync w…
765755f 
…as enabled
TrueBrain pushed a commit that referenced this issue Oct 23, 2021
@LordAro @TrueBrain
Fix #9614: Refresh rate dropdown was still active when vsync was enabled
3072b19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working priority: low This issue should be fixed but has either a low impact or is en edge-case
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TrueBrain @YouYouTheBoxx