Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change: Don't use 'server address' string in server list when displaying an invite code #9615

Merged
merged 1 commit into from Oct 17, 2021
Merged

Change: Don't use 'server address' string in server list when displaying an invite code #9615

merged 1 commit into from Oct 17, 2021

Conversation

LordAro
Copy link
Member

@LordAro LordAro commented Oct 17, 2021

Motivation / Problem

12.0+ servers only use an invite code as a connection string, rather than an IP/port. Using "Server address: " as the prefix for that is a bit confusing

Description

Add a new 'Invite code: ' prefix string

Limitations

Ideally this would be backported, but adding a new string to backports is a bit tricky

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@TrueBrain TrueBrain added the backport requested This PR should be backport to current release (RC / stable) label Oct 17, 2021
@LordAro LordAro merged commit 3b7daca into OpenTTD:master Oct 17, 2021
@LordAro LordAro deleted the serverlist-invite-code branch October 17, 2021 17:14
TrueBrain pushed a commit to TrueBrain/OpenTTD that referenced this pull request Oct 23, 2021
@LordAro @TrueBrain
Change: Don't use 'server address' string in server list when display…
4dc6b54 
…ing an invite code (OpenTTD#9615)
@TrueBrain TrueBrain mentioned this pull request Oct 23, 2021
Merged
TrueBrain pushed a commit that referenced this pull request Oct 23, 2021
@LordAro @TrueBrain
Change: Don't use 'server address' string in server list when display…
8eb646d 
…ing an invite code (#9615)
@TrueBrain TrueBrain added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrueBrain TrueBrain TrueBrain approved these changes

Assignees
No one assigned
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LordAro @TrueBrain