Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3046a6ce: [Preview] building preview failed to patch LZMA #9620

Merged
merged 1 commit into from Oct 17, 2021

Conversation

TrueBrain
Copy link
Member

Motivation / Problem

In 3046a6c I assumed that the CI job and preview job would work the same way. It didn't.

Description

As by commit message:

The job was started under a non-priv user, which did not have
permission to patch the emscripten files required to make LZMA
work.

Limitations

There is no real way of testing this anymore, other than it now did build on my fork. But the publishing part etc can only be checked after merging. Tagging this PR with "preview" doesn't work, as this change needs to be in master before it is picked up. (security blabla).

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

The job was started under a non-priv user, which did not have
permission to patch the emscripten files required to make LZMA
work.
Copy link
Contributor

@glx22 glx22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why preview used a non-root user, but let's try with root.

@TrueBrain TrueBrain merged commit 01603d9 into OpenTTD:master Oct 17, 2021
@TrueBrain TrueBrain deleted the fix-preview branch October 17, 2021 19:59
@TrueBrain TrueBrain added the backport requested This PR should be backport to current release (RC / stable) label Oct 17, 2021
TrueBrain added a commit to TrueBrain/OpenTTD that referenced this pull request Oct 23, 2021
…#9620)

The job was started under a non-priv user, which did not have
permission to patch the emscripten files required to make LZMA
work.
TrueBrain added a commit that referenced this pull request Oct 23, 2021
The job was started under a non-priv user, which did not have
permission to patch the emscripten files required to make LZMA
work.
@TrueBrain TrueBrain added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants