Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 01603d9e: [Preview] publishing preview failed due to recent changes #9621

Merged
merged 1 commit into from Oct 17, 2021
Merged

Fix 01603d9e: [Preview] publishing preview failed due to recent changes #9621

merged 1 commit into from Oct 17, 2021

Conversation

TrueBrain
Copy link
Member

Motivation / Problem

Sadly publishing of previews can only be tested in master. So it is a bit of trial and error .. hopefully I shoot this one right.

Description

As per commit message:

Since 01603d9e we run under root, not under github user. In result,
the location of "aws" changed.

Limitations

I tested that aws becomes available when installing it like this. But couldn't test it actually uploaded correctly.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@TrueBrain
Fix 01603d9: [Preview] publishing preview failed due to recent changes
0dd556a 
Since 01603d9 we run under root, not under github user. In result,
the location of "aws" binary changed.
@TrueBrain TrueBrain merged commit 5bcdf16 into OpenTTD:master Oct 17, 2021
@TrueBrain TrueBrain deleted the fix-preview branch October 17, 2021 20:42
@TrueBrain TrueBrain added the backport requested This PR should be backport to current release (RC / stable) label Oct 17, 2021
TrueBrain added a commit to TrueBrain/OpenTTD that referenced this pull request Oct 23, 2021
@TrueBrain
Fix 01603d9: [Preview] publishing preview failed due to recent changes (
4bc0bc7 
OpenTTD#9621)

Since 01603d9 we run under root, not under github user. In result,
the location of "aws" binary changed.
@TrueBrain TrueBrain mentioned this pull request Oct 23, 2021
Merged
TrueBrain added a commit that referenced this pull request Oct 23, 2021
@TrueBrain
Fix 01603d9: [Preview] publishing preview failed due to recent changes (
465a660 
#9621)

Since 01603d9 we run under root, not under github user. In result,
the location of "aws" binary changed.
@TrueBrain TrueBrain added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glx22 glx22 glx22 approved these changes

Assignees
No one assigned
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TrueBrain @glx22