Feature: Button to toggle showing advanced signal types #9617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordAro
added
the
backport requested
TrueBrain
reviewed
Oct 17, 2021
LordAro
force-pushed
the
signal-gui-resize
branch
from
c86a7a6
to
1d35eb1
Compare
TrueBrain
approved these changes
Oct 17, 2021
This comment was marked as abuse.
This comment was marked as abuse.
|
I don't really understand what you mean. Semaphore sprites are provided by the baseset - they are very definitely different in original_windows & opengfx. Perhaps a screenshot would help demonstrate? Unless of course you're running a NewGRF that overrides them, of course... |
TrueBrain
pushed a commit
to TrueBrain/OpenTTD
that referenced
this pull request
Oct 23, 2021
TrueBrain
pushed a commit
that referenced
this pull request
Oct 23, 2021
TrueBrain
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
The setting for showing the "advanced" pre & block signals is not the most obvious thing in the world.
Description
Add a toggle button, similar to the finance window, that just toggles the setting and reinitialises the window.
Limitations
If you hide advanced signals while block signals are still selected, block signals are still selected and you can still build them until you select something else. Technically no change from changing the setting via the settings window, but that was a bit harder to do..
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.
This PR affects the save game format? (label 'savegame upgrade')This PR affects the GS/AI API? (label 'needs review: Script API')ai_changelog.hpp, gs_changelog.hpp need updating.The compatibility wrappers (compat_*.nut) need updating.This PR affects the NewGRF API? (label 'needs review: NewGRF')newgrf_debug_data.h may need updating.PR must be added to API tracker