Change: Disable AI and Game Script when loading the title game #9608
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Load Game window uses |
|
In my opinion it is very little effort to do this manually once or twice a year. For 12.0 this turned out to be unneeded, as the savegame had no AIs nor GS. But these kind of PRs add technical debt that can also be avoided via other ways. Just my 2 cents, I have no issues if this gets approved and merged :) |
|
I suppose a branch/patch/script that can be broken out when necessary to take out/disable the scripts in a save file may solve the same problem yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
AI players and game scripts can be valuable tools for producing a title screen game, but having to take them out/disable them before shipping the title game is a big hassle. Let's just pretend the AI/GS isn't there when loading the game instead.
Description
Don't load the Game Script data, don't load AI data, and turn AI players into "human" players, when loading a save game and the game mode is menu.
Limitations
I hope this doesn't break detection of missing AI/GS in the Load Game window... as far as I can tell there isn't anything to break there, so it doesn't.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.