Cleanup and simplification of new-style discrete trajectory classes #3152
+238
−291
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things which unfortunately are entangled and hard to separate:
Segments
, so that that list now directly containsDiscreteTrajectorySegment
s instead ofunique_ptr
to the same. This makes the code simpler to understand in many places as it removes a slew of*
and->
.Timeline
s, notSegments
. The former is more useful (it can be used to testDiscreteTrajectory2
) and pulls less dependencies on the various discrete trajectory classes. This in turns makes it possible to drop the mock class, which was not working anymore now that the list doesn't contain pointers.#3136.