Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and simplification of new-style discrete trajectory classes #3152

Merged
merged 6 commits into from
Oct 13, 2021

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Oct 13, 2021

This PR does two things which unfortunately are entangled and hard to separate:

  1. It removes a level of indirection in the list Segments, so that that list now directly contains DiscreteTrajectorySegments instead of unique_ptr to the same. This makes the code simpler to understand in many places as it removes a slew of * and ->.
  2. It changes the trajectory factories to return Timelines, not Segments. The former is more useful (it can be used to test DiscreteTrajectory2) and pulls less dependencies on the various discrete trajectory classes. This in turns makes it possible to drop the mock class, which was not working anymore now that the list doesn't contain pointers.

#3136.

@pleroy pleroy changed the title Cleanup and simplification of new-style discrete trajectory Cleanup and simplification of new-style discrete trajectory classes Oct 13, 2021
@eggrobin eggrobin added the LGTM label Oct 13, 2021
@pleroy pleroy merged commit 5b1b9fb into mockingbirdnest:Ondelette Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants