Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ft2-clone: add a test #94187

Merged
merged 2 commits into from Oct 12, 2020
Merged

ft2-clone: add a test #94187

merged 2 commits into from Oct 12, 2020

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Jul 29, 2020

Motivation for this change

New release, and a test because why not

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fgaz
Copy link
Member Author

fgaz commented Aug 13, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Aug 13, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@symphorien
Copy link
Member

There is a merge conflict
/status awaiting_changes

@fgaz fgaz changed the title ft2-clone: 1.26 -> 1.27, add a test ft2-clone: add a test Sep 7, 2020
@fgaz
Copy link
Member Author

fgaz commented Sep 8, 2020

@symphorien fixed

Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

nixos/tests/ft2-clone.nix Show resolved Hide resolved
@timokau timokau merged commit 787ec15 into NixOS:master Oct 12, 2020
@fgaz fgaz deleted the ft2-clone/1.27 branch October 13, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants