Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.decorator: 4.4.1 -> 4.4.2 #94172

Merged
merged 1 commit into from Jul 31, 2020
Merged

python.pkgs.decorator: 4.4.1 -> 4.4.2 #94172

merged 1 commit into from Jul 31, 2020

Conversation

knedlsepp
Copy link
Member

Motivation for this change

This should fix the build of python39.pkgs.decorator.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@knedlsepp
python.pkgs.decorator: 4.4.1 -> 4.4.2
7e213cc 
This should fix the build of python39.pkgs.decorator.
@ofborg ofborg bot requested a review from costrouc July 29, 2020 13:25
@Mic92
Copy link
Member

Mic92 commented Jul 29, 2020

Should this go to staging?

@knedlsepp knedlsepp changed the base branch from master to staging July 30, 2020 05:12
@knedlsepp
Copy link
Member Author

Should this go to staging?

Done

@FRidh
Copy link
Member

FRidh commented Jul 30, 2020

@GrahamcOfBorg build python.pkgs.decorator python3.pkgs.decorator

1 similar comment
@Mic92
Copy link
Member

Mic92 commented Jul 31, 2020

@GrahamcOfBorg build python.pkgs.decorator python3.pkgs.decorator

@FRidh FRidh merged commit 8544c5d into NixOS:staging Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@knedlsepp @Mic92 @FRidh