mgit: Init at 0.1.10 #94173
Closed
mgit: Init at 0.1.10 #94173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sikmir
reviewed
Jul 29, 2020
sikmir
approved these changes
Jul 31, 2020
timstott
reviewed
Aug 3, 2020
maintainers/maintainer-list.nix
Outdated
| @@ -9203,4 +9203,10 @@ | |||
| github = "deifactor"; | |||
| githubId = 30192992; | |||
| }; | |||
| koozz = { | |||
There was a problem hiding this comment.
🔡 Users are mostly inserted by alphabetical order. Could you find the next best spot for your username.
There was a problem hiding this comment.
I see, the last few were totally unordered and that made me think it was chronological. I've put myself in the ordered part now.
timstott
suggested changes
Aug 3, 2020
timstott
reviewed
Aug 4, 2020
maintainers/maintainer-list.nix
Outdated
| name = "Jan van den Berg"; | ||
| email = "264371+koozz@users.noreply.github.com"; | ||
| github = "koozz"; | ||
| githubId = 264371; |
There was a problem hiding this comment.
I believe the githubId is off by one 😬
curl -s https://api.github.com/users/koozz | jq .id
264372
There was a problem hiding this comment.
Weird, I found the noreply-email in my GitHub settings and copied that. Fixed it now.
timstott
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Commandline tool written in Rust by myself.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)