New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LottieConverter: init at r0.1.1 & rlottie: init at v0.1 #94197
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CRTified
force-pushed
the
pkg/lottieconverter
branch
2 times, most recently
from
July 29, 2020 22:22
9a851d5
to
7a55df5
Compare
CRTified
force-pushed
the
pkg/lottieconverter
branch
from
July 30, 2020 08:44
7a55df5
to
5032191
Compare
fionera
suggested changes
Jul 30, 2020
CRTified
force-pushed
the
pkg/lottieconverter
branch
from
July 30, 2020 22:52
5032191
to
37efd6e
Compare
fionera
approved these changes
Jul 30, 2020
jtojnar
reviewed
Aug 10, 2020
jtojnar
reviewed
Aug 10, 2020
jtojnar
reviewed
Aug 10, 2020
jtojnar
reviewed
Aug 10, 2020
CRTified
force-pushed
the
pkg/lottieconverter
branch
2 times, most recently
from
August 10, 2020 11:54
79b79ec
to
f1432bd
Compare
jtojnar
reviewed
Aug 10, 2020
jtojnar
reviewed
Aug 10, 2020
jtojnar
reviewed
Aug 10, 2020
CRTified
force-pushed
the
pkg/lottieconverter
branch
from
August 10, 2020 12:48
f1432bd
to
a8a7185
Compare
jtojnar
approved these changes
Aug 10, 2020
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
According to the source of mautrix-telegram, this binary (and indirectly
rlottie
as a library) is required to convert animated telegram stickers to a different format. Asmautrix-telegram
has a module (#63589 ) in unstable, it would make sense to care for this feature.I'm unsure whether the derivation for
rlottie
is written correctly. The cmake script seems a bit broken, as most variables are not used. It also has a very mixed license usage (from MIT over custom unfree licenses), so I was unsure whether I should list all of them, and went the most restrictive path.LottieConverter has its license written in the code file.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)