Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LottieConverter: init at r0.1.1 & rlottie: init at v0.1 #94197

Merged
merged 2 commits into from Aug 10, 2020

Conversation

CRTified
Copy link
Contributor

@CRTified CRTified commented Jul 29, 2020

Motivation for this change

According to the source of mautrix-telegram, this binary (and indirectly rlottie as a library) is required to convert animated telegram stickers to a different format. As mautrix-telegram has a module (#63589 ) in unstable, it would make sense to care for this feature.

I'm unsure whether the derivation for rlottie is written correctly. The cmake script seems a bit broken, as most variables are not used. It also has a very mixed license usage (from MIT over custom unfree licenses), so I was unsure whether I should list all of them, and went the most restrictive path.
LottieConverter has its license written in the code file.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pkgs/development/libraries/rlottie/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/rlottie/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/lottieconverter/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/lottieconverter/default.nix Outdated Show resolved Hide resolved
@CRTified CRTified force-pushed the pkg/lottieconverter branch 2 times, most recently from 79b79ec to f1432bd Compare August 10, 2020 11:54
@CRTified CRTified requested a review from jtojnar August 10, 2020 12:13
@jtojnar jtojnar merged commit 0c3b48b into NixOS:master Aug 10, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Aug 10, 2020

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants