Split iceGatheringState tests into separate files & update expectations #24797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 29, 2020
This allows us to run more tests than if we mark a single file as timing out. Important to ensure we don't cause regressions when rolling https://webrtc-review.googlesource.com/c/src/+/180481 into chromium. # TBR since I am just moving things around and want to unblock a reland TBR=hta@chromium.org Bug: chromium:1110833, chromium:1071733 Change-Id: Ib9f9cefe3fd89d764495a41a66422f191761df62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324251 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#792650}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2324251
branch
from
0ed702c
to
7f5307d
Compare
|
Firefox failure is due to a slow test approaching timeout limit Unstable results
A helper file was changed so lots of tests got rerun, but code was only moved around so should be a no-op. The flaky test above doesn't use any of the code that was modified in this CL. Also, can't reproduce the flake locally at ToT. Retrying here, but will likely force-merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to run more tests than if we mark a single file as
timing out. Important to ensure we don't cause regressions when rolling
https://webrtc-review.googlesource.com/c/src/+/180481 into chromium.
TBR since I am just moving things around and want to unblock a reland
TBR=hta@chromium.org
Bug: chromium:1110833, chromium:1071733
Change-Id: Ib9f9cefe3fd89d764495a41a66422f191761df62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324251
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792650}