Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tor-browser-bundle-bin: 9.5 -> 9.5.3; fix missing source #94200

Closed
wants to merge 1 commit into from
Closed

tor-browser-bundle-bin: 9.5 -> 9.5.3; fix missing source #94200

wants to merge 1 commit into from

Conversation

yurkobb
Copy link
Contributor

@yurkobb yurkobb commented Jul 29, 2020

Motivation for this change

The 9.5 release doesn't seem to be present on torproject.org anymore; that made it impossible to build the package with 9.5, hence the upgrade. Also, Tor Browser updates are often about security fixes, so probably this is worth backporting to 20.03 too.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@yurkobb yurkobb mentioned this pull request Jul 30, 2020
Closed
prusnak
prusnak approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works

@colemickens colemickens mentioned this pull request Jul 30, 2020
Closed
jonringer
jonringer approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

@jonringer
Copy link
Contributor

I preferred #94019 because it was opened first. But @yurkobb thank you for opening a PR :)

@jonringer jonringer closed this Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yurkobb @jonringer @prusnak