Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvidia-docker: remove ldconf patch (fixes #93511) #94199

Merged

Conversation

Philipp-M
Copy link
Member

Motivation for this change

#93511
The bug listed in

# https://sourceware.org/bugzilla/show_bug.cgi?id=23964 and
was fixed by https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=58e8f5fd2ba47b6dc47fd4d0a35e4175c7c87aaa

Thus the applied patch isn't necessary anymore (and breaks this package)

Things done

Removed the redundant patch.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 29, 2020
@marsam marsam merged commit 7771568 into NixOS:master Jul 30, 2020
@Philipp-M Philipp-M deleted the fix-nvidia-docker-glibc-ldconfig-patch branch September 16, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants