Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soundtracker: 1.0.0.1 -> 1.0.1 #94196

Merged
merged 1 commit into from Jul 30, 2020
Merged

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Jul 29, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fgaz
Copy link
Member Author

fgaz commented Jul 29, 2020

/marvin opt-in
/marvin needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Jul 29, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Jul 29, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@fgaz
Copy link
Member Author

fgaz commented Jul 29, 2020

Will I ever get it right?

/status needs_reviewer

@bjornfor bjornfor merged commit 7141271 into NixOS:master Jul 30, 2020
@fgaz fgaz deleted the soundtracker/1.0.1 branch July 30, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants