Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the-powder-toy: 94.1 -> 95.0 #94170

Closed
wants to merge 5 commits into from
Closed

the-powder-toy: 94.1 -> 95.0 #94170

wants to merge 5 commits into from

Conversation

siraben
Copy link
Member

@siraben siraben commented Jul 29, 2020 •
edited

Motivation for this change

Update the-powder-toy from 94.1 to 95.0.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from abbradar July 29, 2020 13:32
dasj19
dasj19 approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@dasj19 dasj19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built with nix-shell -p nixpkgs-review --run "nixpkgs-review pr 94170"

The powder executable runs fine.

@siraben
Copy link
Member Author

siraben commented Jul 29, 2020

Don't merge yet, I'll commit a change so that it builds on Darwin as well.

@Mic92 Mic92 marked this pull request as draft July 29, 2020 21:54
@siraben siraben marked this pull request as ready for review July 30, 2020 01:03
@siraben
Copy link
Member Author

siraben commented Jul 31, 2020

Ready to merge.

@siraben siraben closed this Aug 8, 2020
@siraben siraben deleted the powder-v95 branch August 8, 2020 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasj19 dasj19 dasj19 approved these changes

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@siraben @dasj19