Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openttd: 1.10.2 -> 1.10.3 #95197

Merged
merged 1 commit into from Aug 11, 2020
Merged

openttd: 1.10.2 -> 1.10.3 #95197

merged 1 commit into from Aug 11, 2020

Conversation

SFrijters
Copy link
Member

Motivation for this change

Bugfix release https://cdn.openttd.org/openttd-releases/1.10.3/changelog.txt

Opened up an old save and it seems to work just fine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
Copy link
Member

Starts and looks playable.

Result of nixpkgs-review pr 95197 1

1 package built:
- openttd

@mweinelt mweinelt merged commit 072501e into NixOS:master Aug 11, 2020
@SFrijters SFrijters deleted the openttd-1.10.3 branch September 30, 2020 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SFrijters @mweinelt